[tor-commits] [Git][tpo/applications/firefox-android][firefox-android-115.2.1-13.5-1] 2 commits: fixup! Bug 1823316 - Use 'Snackbar' themed Dialog to notify on making app full-screen

[ma1 (@ma1)]

ma1 pushed to branch firefox-android-115.2.1-13.5-1 at The Tor Project / Applications / firefox-android


Commits:
a57e5d10 by hackademix at 2024-01-10T08:41:06+01:00
fixup! Bug 1823316 - Use 'Snackbar' themed Dialog to notify on making app full-screen

Fix tor-browser#42355 backporting regression.

- - - - -
c1397e81 by t-p-white at 2024-01-10T08:41:06+01:00
Bug 1864549 - Fix for IllegalStateException in full screen notification dialog

- - - - -


2 changed files:

- android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/FullScreenNotificationDialog.kt
- fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt


Changes:

=====================================
android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/dialog/FullScreenNotificationDialog.kt
=====================================
@@ -59,11 +59,12 @@ class FullScreenNotificationDialog(@LayoutRes val layout: Int) :
                 window.setGravity(Gravity.BOTTOM)
                 window.clearFlags(WindowManager.LayoutParams.FLAG_DIM_BEHIND)
             }
+        }
 
-            lifecycleScope.launch {
-                delay(SNACKBAR_DURATION_LONG_MS)
-                dismiss()
-            }
+        // Attempt to automatically dismiss the dialog after the given duration.
+        lifecycleScope.launch {
+            delay(SNACKBAR_DURATION_LONG_MS)
+            dialog?.dismiss()
         }
     }
 }


=====================================
fenix/app/src/main/java/org/mozilla/fenix/browser/BaseBrowserFragment.kt
=====================================
@@ -1491,6 +1491,7 @@ abstract class BaseBrowserFragment :
                 parentFragmentManager,
             )
 
+            activity?.enterToImmersiveMode()
             (view as? SwipeGestureLayout)?.isSwipeEnabled = false
             browserToolbarView.collapse()
             browserToolbarView.view.isVisible = false



View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/be02ec8601e43571da6c25a504f4633e54fd72e7...c1397e812f0a6cecfc44af411d6b7f222fc99164

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/firefox-android/-/compare/be02ec8601e43571da6c25a504f4633e54fd72e7...c1397e812f0a6cecfc44af411d6b7f222fc99164
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20240110/5c28414a/attachment-0001.htm>