[tor-commits] [Git][tpo/applications/tor-browser][base-browser-115.4.0esr-13.5-1] Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.

[ma1 (@ma1)]

ma1 pushed to branch base-browser-115.4.0esr-13.5-1 at The Tor Project / Applications / Tor Browser


Commits:
c06034d3 by hackademix at 2023-11-07T17:19:49+01:00
Bug 42194: Fix blank net error page on failed DNS resolution with active proxy.

- - - - -


1 changed file:

- toolkit/actors/NetErrorChild.sys.mjs


Changes:

=====================================
toolkit/actors/NetErrorChild.sys.mjs
=====================================
@@ -133,12 +133,15 @@ export class NetErrorChild extends RemotePageChild {
         shortDesc.appendChild(span);
       },
     };
-
-    Services.uriFixup.checkHost(
-      info.fixedURI,
-      onLookupCompleteListener,
-      this.document.nodePrincipal.originAttributes
-    );
+    try {
+      Services.uriFixup.checkHost(
+        info.fixedURI,
+        onLookupCompleteListener,
+        this.document.nodePrincipal.originAttributes
+      );
+    } catch (e) {
+      // DNS resolution may fail synchronously if forbidden by proxy
+    }
   }
 
   // Get the header from the http response of the failed channel. This function



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c06034d3b43a8cb1db0b155527901124924355e5

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/c06034d3b43a8cb1db0b155527901124924355e5
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20231107/d0e0c039/attachment-0001.htm>