[tor-commits] [tor/maint-0.4.6] protover: Add a note on why LinkAuth is not recommended or required

[dgoulet at torproject.org]

commit f93cd5deb8f4731920043016c082e44e81afcfbf
Author: David Goulet <dgoulet at torproject.org>
Date:   Fri Nov 5 10:16:08 2021 -0400

    protover: Add a note on why LinkAuth is not recommended or required
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 src/core/or/protover.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/core/or/protover.c b/src/core/or/protover.c
index 0183704c2c..8075dd425c 100644
--- a/src/core/or/protover.c
+++ b/src/core/or/protover.c
@@ -462,6 +462,13 @@ protover_get_supported_protocols(void)
  * XXX: WARNING!
  */
 
+/*
+ * NOTE: A keen observer will notice that "LinkAuth" is not recommended nor
+ * required.  This is due to the HAVE_WORKING_TOR_TLS_GET_TLSSECRETS define
+ * that can either set "1" or "1,3" and so we can't enforce one or the other
+ * due to this uncertainty on how tor was built.
+ */
+
 /** Return the recommended client protocols list that directory authorities
  * put in the consensus. */
 const char *