[tor-commits] [sbws/maint-1.1] fix:scanner: Rm condition assigning helper

[juga at torproject.org]

commit 72b43570589d10a668039341895948ded0f1bfd7
Author: juga0 <juga at riseup.net>
Date:   Tue Feb 9 13:08:44 2021 +0000

    fix:scanner: Rm condition assigning helper
---
 sbws/core/scanner.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sbws/core/scanner.py b/sbws/core/scanner.py
index 97829f4..5fd917a 100644
--- a/sbws/core/scanner.py
+++ b/sbws/core/scanner.py
@@ -267,12 +267,12 @@ def error_no_helper(relay, dest, our_nick=""):
 
 
 def create_path_relay(relay, dest, rl, cb, relay_as_entry=True):
-    if relay_as_entry:
-        helper = _pick_ideal_second_hop(
-            relay, dest, rl, cb.controller, is_exit=True)
-    else:
-        helper = _pick_ideal_second_hop(
-            relay, dest, rl, cb.controller, is_exit=False)
+    # the helper `is_exit` arg (should be better called `helper_as_exit`),
+    # is True when the relay is the entry (helper has to be exit)
+    # and False when the relay is not the entry, ie. is the exit (helper does
+    # not have to be an exit)
+    helper = _pick_ideal_second_hop(
+            relay, dest, rl, cb.controller, is_exit=relay_as_entry)
     if not helper:
         return error_no_helper(relay, dest)
     if relay_as_entry: