[tor-commits] [tor-browser/tor-browser-78.8.0esr-10.5-2] Bug 3547: Block all plugins.

[sysrqb at torproject.org]

commit 006304880e19ccbc77ba678eba3254491f94dcc8
Author: Mike Perry <mikeperry-git at torproject.org>
Date:   Tue Dec 4 16:03:13 2012 -0800

    Bug 3547: Block all plugins.
    
    We cannot use the @mozilla.org/extensions/blocklist;1 service, because we
    actually want to stop plugins from ever entering the browser's process space
    and/or executing code (for example, AV plugins that collect statistics/analyse
    urls, magical toolbars that phone home or "help" the user, skype buttons that
    ruin our day, and censorship filters). Hence we rolled our own.
    
    See https://trac.torproject.org/projects/tor/ticket/3547#comment:6 for musings
    on a better way. Until then, it is delta-darwinism for us.
---
 dom/plugins/base/PluginFinder.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dom/plugins/base/PluginFinder.cpp b/dom/plugins/base/PluginFinder.cpp
index 4e1c1fd53698..cace7d4ef6ba 100644
--- a/dom/plugins/base/PluginFinder.cpp
+++ b/dom/plugins/base/PluginFinder.cpp
@@ -480,6 +480,9 @@ nsresult PluginFinder::ScanPluginsDirectory(nsIFile* pluginsDir,
 
   *aPluginsChanged = false;
 
+  // Block all plugins
+  return NS_OK;
+
 #ifdef PLUGIN_LOGGING
   nsAutoCString dirPath;
   pluginsDir->GetNativePath(dirPath);