[tor-commits] [tor/release-0.4.3] Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()

[nickm at torproject.org]

commit 460b97380bdb7187c2b2e924aa1a2940afd6035d
Author: Neel Chauhan <neel at neelc.org>
Date:   Thu Dec 5 19:06:35 2019 -0500

    Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()
---
 changes/ticket32672                 |  4 ++++
 src/feature/dirauth/process_descs.c | 21 ++++++++++-----------
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/changes/ticket32672 b/changes/ticket32672
new file mode 100644
index 000000000..351329ba2
--- /dev/null
+++ b/changes/ticket32672
@@ -0,0 +1,4 @@
+  o Minor features (directory authorities):
+    - Directory authorities now reject descriptors from relays running Tor
+      versions from the 0.2.9 and 0.4.0 series, but still allow the 0.3.5
+      series. Resolves ticket 32672. Patch by Neel Chauhan.
diff --git a/src/feature/dirauth/process_descs.c b/src/feature/dirauth/process_descs.c
index 760560a5d..b4dbc8975 100644
--- a/src/feature/dirauth/process_descs.c
+++ b/src/feature/dirauth/process_descs.c
@@ -326,22 +326,21 @@ dirserv_rejects_tor_version(const char *platform,
   static const char please_upgrade_string[] =
     "Tor version is insecure or unsupported. Please upgrade!";
 
-  /* Versions before Tor 0.2.9 are unsupported. Versions between 0.2.9.0 and
-   * 0.2.9.4 suffer from bug #20499, where relays don't keep their consensus
-   * up to date */
-  if (!tor_version_as_new_as(platform,"0.2.9.5-alpha")) {
+  /* Versions before Tor 0.3.5 are unsupported.
+   *
+   * Also, reject unstable versions of 0.3.5, since (as of this writing)
+   * they are almost none of the network. */
+  if (!tor_version_as_new_as(platform,"0.3.5.7")) {
     if (msg)
       *msg = please_upgrade_string;
     return true;
   }
 
-  /* Series between Tor 0.3.0 and 0.3.4 inclusive are unsupported, and some
-   * have bug #27841, which makes them broken as intro points. Reject them.
-   *
-   * Also reject unstable versions of 0.3.5, since (as of this writing)
-   * they are almost none of the network. */
-  if (tor_version_as_new_as(platform,"0.3.0.0-alpha-dev") &&
-      !tor_version_as_new_as(platform,"0.3.5.7")) {
+  /* Series between Tor 0.3.6 and 0.4.1.4-rc inclusive are unsupported.
+   * Reject them. 0.3.6.0-alpha-dev only existed for a short time, before
+   * it was renamed to 0.4.0.0-alpha-dev. */
+  if (tor_version_as_new_as(platform,"0.3.6.0-alpha-dev") &&
+      !tor_version_as_new_as(platform,"0.4.1.5")) {
     if (msg) {
       *msg = please_upgrade_string;
     }