[tor-commits] [snowflake/master] Remove unecessary log messages

cohosh at torproject.org cohosh at torproject.org
Tue Feb 25 23:09:01 UTC 2020


commit 2e9e8071787398d9713395d94d93b5427ac8d452
Author: Cecylia Bocovich <cohosh at torproject.org>
Date:   Wed Feb 19 17:26:29 2020 -0500

    Remove unecessary log messages
    
    Ever since we started scrubbing log messages, with the help of regexes
    for https://bugs.torproject.org/21304 logging has become more CPU
    intensive due to our use of regular expressions.
    
    Logging the byte count of every incoming and outgoing message at the
    proxy-go instances was taking up a lot of CPU and contrubuting to the
    high CPU usage seen in https://bugs.torproject.org/33211.
---
 proxy-go/snowflake.go | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/proxy-go/snowflake.go b/proxy-go/snowflake.go
index e964a07..5e56842 100644
--- a/proxy-go/snowflake.go
+++ b/proxy-go/snowflake.go
@@ -90,8 +90,6 @@ func (c *webRTCConn) Read(b []byte) (int, error) {
 func (c *webRTCConn) Write(b []byte) (int, error) {
 	c.lock.Lock()
 	defer c.lock.Unlock()
-	// log.Printf("webrtc Write %d %+q", len(b), string(b))
-	log.Printf("Write %d bytes --> WebRTC", len(b))
 	if c.dc != nil {
 		c.dc.Send(b)
 	}
@@ -320,7 +318,6 @@ func makePeerConnectionFromOffer(sdp *webrtc.SessionDescription, config webrtc.C
 			pw.Close()
 		})
 		dc.OnMessage(func(msg webrtc.DataChannelMessage) {
-			log.Printf("OnMessage <--- %d bytes", len(msg.Data))
 			var n int
 			n, err = pw.Write(msg.Data)
 			if err != nil {



More information about the tor-commits mailing list