[tor-commits] [tor/master] Fix a memory leak in handling GETINFO.

[nickm at torproject.org]

commit 56c54a66bdc01a9e8b857f22650ca88d8eff5466
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Feb 5 19:18:32 2020 -0500

    Fix a memory leak in handling GETINFO.
    
    Fixes bug 33103; bugfix on 0.4.3.1-alpha.
---
 changes/ticket33103                   | 3 +++
 src/feature/control/control_getinfo.c | 1 +
 2 files changed, 4 insertions(+)

diff --git a/changes/ticket33103 b/changes/ticket33103
new file mode 100644
index 000000000..889805f10
--- /dev/null
+++ b/changes/ticket33103
@@ -0,0 +1,3 @@
+  o Minor bugfixes (controller):
+    - Fix a memory leak in GETINFO responses. Fixes bug 33103;
+      bugfix on 0.4.3.1-alpha.
diff --git a/src/feature/control/control_getinfo.c b/src/feature/control/control_getinfo.c
index 6f30878d2..5dcc4b170 100644
--- a/src/feature/control/control_getinfo.c
+++ b/src/feature/control/control_getinfo.c
@@ -1735,6 +1735,7 @@ handle_control_getinfo(control_connection_t *conn,
       }
     } else {
       control_reply_add_one_kv(answers, 250, KV_RAW, q, ans);
+      tor_free(ans);
     }
   } SMARTLIST_FOREACH_END(q);