[tor-commits] [tor/master] Fix memleak when failing to parse a CSV_INTERVAL.

[dgoulet at torproject.org]

commit 4ab1d1c0c44a887417b04fc75b1b11bf246f2bb5
Author: Nick Mathewson <nickm at torproject.org>
Date:   Sat Jun 15 16:47:16 2019 -0400

    Fix memleak when failing to parse a CSV_INTERVAL.
    
    Fixes bug 30894; bugfix on 0.3.4.1-alpha
---
 changes/bug30894           | 4 ++++
 src/app/config/confparse.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/changes/bug30894 b/changes/bug30894
new file mode 100644
index 000000000..64c14c4e6
--- /dev/null
+++ b/changes/bug30894
@@ -0,0 +1,4 @@
+  o Minor bugfixes (memory leaks):
+    - Fix a trivial memory leak when parsing an invalid value
+      from a download schedule in the configuration. Fixes bug
+      30894; bugfix on 0.3.4.1-alpha.
diff --git a/src/app/config/confparse.c b/src/app/config/confparse.c
index 8681f648d..729e7a447 100644
--- a/src/app/config/confparse.c
+++ b/src/app/config/confparse.c
@@ -225,6 +225,7 @@ config_assign_value(const config_format_t *fmt, void *options,
       tor_asprintf(msg,
           "Interval '%s %s' is malformed or out of bounds.",
           c->key, c->value);
+      tor_free(tmp);
       return -1;
     }
     *(int *)lvalue = i;