[tor-commits] [tor/maint-0.3.5] test/shared-random: Stop leaking shared random state in the unit tests

[teor at torproject.org]

commit 4d9eb4dd0e67190f8e3bf5300e85611d8605400c
Author: teor <teor at torproject.org>
Date:   Tue Feb 26 22:14:30 2019 +1000

    test/shared-random: Stop leaking shared random state in the unit tests
    
    Stop leaking parts of the shared random state in the shared-random unit
    tests.
    
    Fixes bug 29599; bugfix on 0.2.9.1-alpha.
---
 changes/bug29599              | 3 +++
 src/test/test_shared_random.c | 5 +++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/changes/bug29599 b/changes/bug29599
new file mode 100644
index 000000000..14e2f5d07
--- /dev/null
+++ b/changes/bug29599
@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory management, testing):
+    - Stop leaking parts of the shared random state in the shared-random unit
+      tests. Fixes bug 29599; bugfix on 0.2.9.1-alpha.
diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c
index 6a8c1abaf..cebe772d9 100644
--- a/src/test/test_shared_random.c
+++ b/src/test/test_shared_random.c
@@ -594,8 +594,8 @@ test_vote(void *arg)
   }
 
  done:
-  sr_commit_free(our_commit);
   UNMOCK(trusteddirserver_get_by_v3_auth_digest);
+  sr_state_free();
 }
 
 static const char *sr_state_str = "Version 1\n"
@@ -829,6 +829,7 @@ test_sr_compute_srv(void *arg)
 
  done:
   UNMOCK(trusteddirserver_get_by_v3_auth_digest);
+  sr_state_free();
 }
 
 /** Return a minimal vote document with a current SRV value set to
@@ -1094,7 +1095,7 @@ test_state_transition(void *arg)
   }
 
  done:
-  return;
+  sr_state_free();
 }
 
 static void