[tor-commits] [tor-browser/tor-browser-60.5.0esr-8.5-1] fixup! Bug 23247: Communicating security expectations for .onion

[gk at torproject.org]

commit 71eb1c774844d5662184914f4defd76110fe0ef7
Author: Georg Koppen <gk at torproject.org>
Date:   Mon Feb 4 09:09:10 2019 +0000

    fixup! Bug 23247: Communicating security expectations for .onion
    
    This commit fixes #29327.
---
 browser/base/content/pageinfo/security.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/browser/base/content/pageinfo/security.js b/browser/base/content/pageinfo/security.js
index 5a827488ccad..ef12ddb0099f 100644
--- a/browser/base/content/pageinfo/security.js
+++ b/browser/base/content/pageinfo/security.js
@@ -52,7 +52,10 @@ var security = {
       (ui.state & Ci.nsIWebProgressListener.STATE_IS_INSECURE);
     var isEV =
       (ui.state & Ci.nsIWebProgressListener.STATE_IDENTITY_EV_TOPLEVEL);
-    var isOnion = hostName.endsWith(".onion");
+    var isOnion = false;
+    if (hostName && hostName.endsWith(".onion")) {
+      isOnion = true;
+    }
 
     ui.QueryInterface(nsISSLStatusProvider);
     var status = ui.SSLStatus;