[tor-commits] [tpo/staging] ui review - people

[hiro at torproject.org]

commit a5ed97e789206ce4682321636dcd375d2258e600
Author: Antonela <hola at antonela.me>
Date:   Mon Jan 28 14:12:06 2019 -0300

    ui review - people
---
 assets/static/images/{png => tb85}/tb85.png    | Bin
 assets/static/images/{png => tb85}/tb85 at 2x.png | Bin
 content/about/people/ssteele-core/contents.lr  |  15 +++++++++++++++
 content/about/people/ssteele/contents.lr       |   8 ++++----
 templates/macros/people.html                   |  22 +++++++++++++---------
 5 files changed, 32 insertions(+), 13 deletions(-)

diff --git a/assets/static/images/png/tb85.png b/assets/static/images/tb85/tb85.png
similarity index 100%
rename from assets/static/images/png/tb85.png
rename to assets/static/images/tb85/tb85.png
diff --git a/assets/static/images/png/tb85 at 2x.png b/assets/static/images/tb85/tb85 at 2x.png
similarity index 100%
rename from assets/static/images/png/tb85 at 2x.png
rename to assets/static/images/tb85/tb85 at 2x.png
diff --git a/content/about/people/ssteele-core/contents.lr b/content/about/people/ssteele-core/contents.lr
new file mode 100644
index 0000000..124fb62
--- /dev/null
+++ b/content/about/people/ssteele-core/contents.lr
@@ -0,0 +1,15 @@
+_model: person
+---
+role: core
+---
+name: Shari Steele
+---
+nickname: ssteele
+---
+pronoun: she
+---
+twitter_handle: ssteele1234
+---
+description:
+
+Shari Steele is on the board of directors for the Tor Project.
diff --git a/content/about/people/ssteele/contents.lr b/content/about/people/ssteele/contents.lr
index 124fb62..d3a7b01 100644
--- a/content/about/people/ssteele/contents.lr
+++ b/content/about/people/ssteele/contents.lr
@@ -1,15 +1,15 @@
 _model: person
 ---
-role: core
+role: board
 ---
 name: Shari Steele
 ---
-nickname: ssteele
+title: ------
 ---
-pronoun: she
+nickname: ssteele
 ---
 twitter_handle: ssteele1234
 ---
 description:
 
-Shari Steele is on the board of directors for the Tor Project.
+Shari Steele is on the board of directors for the Tor Project and needs a bio here.
diff --git a/templates/macros/people.html b/templates/macros/people.html
index e25caec..1e1c3e2 100644
--- a/templates/macros/people.html
+++ b/templates/macros/people.html
@@ -1,20 +1,24 @@
 {% macro render_board(item, alternative) %}
-  <div class="card col-3 m-4 mx-auto">
-    <div class="card-body">
-      <h5 class="card-title human-name">{{ item.name }}</h5>
-      <h6 class="card-subtitle mb-2 text-primary nick text-capitalize">{{ item.title }}</h6>
-      <h6 class="card-subtitle mb-2 text-primary nick text-capitalize">{{ item.nickname }}{% if item.twitter_handle %} - <a href="https://twitter.com/{{ item.twitter_handle }}">@{{ item.twitter_handle }}</a>{% endif %}</h6>
-      {{ item.description }}
+  <div class="col-3 my-4">
+    <div class="card h-100 my-2">
+      <div class="card-body">
+        <h5 class="card-title human-name">{{ item.name }}</h5>
+        <h6 class="card-subtitle mb-2 text-primary nick text-capitalize">{{ item.title }}</h6>
+        <h6 class="card-subtitle mb-2 text-primary nick text-capitalize">{{ item.nickname }}{% if item.twitter_handle %} - <a href="https://twitter.com/{{ item.twitter_handle }}">@{{ item.twitter_handle }}</a>{% endif %}</h6>
+        {{ item.description }}
+      </div>
     </div>
   </div>
 {% endmacro %}
 
 {% macro render_core(item, alternative) %}
-  <div class="card border-1 col-2 m-3">
+  <div class="col-2 my-3">
+  <div class="card h-100">
     <div class="card-body">
-      <h5 class="card-title human-name human-name-small">{{ item.name }}</h5>
-      <h6 class="card-subtitle mb-2 text-primary nick text-lowercase">{{ item.nickname }}{% if item.pronoun %} - {{ item.pronoun }}{% endif %}{% if item.twitter_handle %} - <a href="https://twitter.com/{{ item.twitter_handle }}">@{{ item.twitter_handle }}</a>{% endif %}</h6>
+      <h5 class="card-title human-name human-name-small">{{ item.name }}{% if item.pronoun %} <small class="nick text-primary">{{ item.pronoun }}</small>{% endif %}</h5>
+      <h6 class="card-subtitle mb-2 text-primary nick text-lowercase">{{ item.nickname }}{% if item.twitter_handle %} - <a href="https://twitter.com/{{ item.twitter_handle }}">@{{ item.twitter_handle }}</a>{% endif %}</h6>
       {{ item.description }}
     </div>
   </div>
+  </div>
 {% endmacro %}