[tor-commits] [tor/master] In cancel_descriptor_fetches(), use connection_list_by_type_purpose() instead of connection_list_by_type_state()

[asn at torproject.org]

commit a8b5b9a1bce34e8781a69accd35d9ba9fddac80e
Author: Neel Chauhan <neel at neelc.org>
Date:   Thu Dec 5 13:40:49 2019 -0500

    In cancel_descriptor_fetches(), use connection_list_by_type_purpose() instead of connection_list_by_type_state()
---
 changes/bug32639           | 4 ++++
 src/feature/hs/hs_client.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/changes/bug32639 b/changes/bug32639
new file mode 100644
index 000000000..1237ba074
--- /dev/null
+++ b/changes/bug32639
@@ -0,0 +1,4 @@
+  o Minor bugfixes (onion services):
+    - In cancel_descriptor_fetches(), use connection_list_by_type_purpose()
+      instead of connection_list_by_type_state(). Fixes bug 32639; bugfix on
+      0.3.2.1-alpha. Patch by Neel Chauhan.
diff --git a/src/feature/hs/hs_client.c b/src/feature/hs/hs_client.c
index b5030da47..6656ab2ed 100644
--- a/src/feature/hs/hs_client.c
+++ b/src/feature/hs/hs_client.c
@@ -145,7 +145,7 @@ static void
 cancel_descriptor_fetches(void)
 {
   smartlist_t *conns =
-    connection_list_by_type_state(CONN_TYPE_DIR, DIR_PURPOSE_FETCH_HSDESC);
+    connection_list_by_type_purpose(CONN_TYPE_DIR, DIR_PURPOSE_FETCH_HSDESC);
   SMARTLIST_FOREACH_BEGIN(conns, connection_t *, conn) {
     const hs_ident_dir_conn_t *ident = TO_DIR_CONN(conn)->hs_ident;
     if (BUG(ident == NULL)) {