[tor-commits] [meek/master] Note anticipated problems with proxy.settings.set in FF 67+.

[dcf at torproject.org]

commit 264bf24579caba974f330cb854680dcbb171879a
Author: David Fifield <david at bamsoftware.com>
Date:   Tue Aug 27 11:22:50 2019 -0600

    Note anticipated problems with proxy.settings.set in FF 67+.
---
 webextension/browser/background.js | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/webextension/browser/background.js b/webextension/browser/background.js
index 5a23134..4d8c8c2 100644
--- a/webextension/browser/background.js
+++ b/webextension/browser/background.js
@@ -300,6 +300,15 @@ browser.webRequest.onErrorOccurred.addListener(
 // Firefox 63 because of a bug.
 // https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings
 // https://bugzilla.mozilla.org/show_bug.cgi?id=1487121
+//
+// This proxy.settings.set call may cause a problem in Firefox 67+, because in
+// those versions, extensions additionally need the "Run in Private Windows"
+// permission to use proxy.settings.set at all (not only in private windows).
+// Lacking the permission, you get an error in the browser console: "Error:
+// proxy.settings requires private browsing permission." We will need to find a
+// way to install the extension such that it has the necessary permission.
+// https://bugzilla.mozilla.org/show_bug.cgi?id=1525447
+// https://bugzilla.mozilla.org/show_bug.cgi?id=1526299
 browser.proxy.settings.set({value: {proxyType: "system", proxyDNS: false}});
 
 // Connect to our native process.