[tor-commits] [tor/master] Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care

[dgoulet at torproject.org]

commit d6a3636cdcb2556e99744dc3685db2010e151291
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Jul 17 15:28:48 2019 +0200

    Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care
    
    Fixes part of bug 30752
---
 Makefile.am                              | 4 +++-
 scripts/maint/practracker/practracker.py | 3 +++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index e823f9e10..d6ea72c17 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -369,7 +369,9 @@ endif
 
 check-best-practices:
 if USEPYTHON
-	$(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir)
+	@if test "$$TOR_DISABLE_PRACTRACKER" = ""; then \
+		$(PYTHON) $(top_srcdir)/scripts/maint/practracker/practracker.py $(top_srcdir); \
+	fi
 endif
 
 practracker-regen:
diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py
index 75cd44d22..70035a0ab 100755
--- a/scripts/maint/practracker/practracker.py
+++ b/scripts/maint/practracker/practracker.py
@@ -227,6 +227,9 @@ Please fix the problems if you can, and update the exceptions file
 ({}) if you can't.
 
 See doc/HACKING/HelpfulTools.md for more information on using practracker.\
+
+You can disable this message by setting the TOR_DISABLE_PRACTRACKER environment
+variable.
 """.format(found_new_issues, exceptions_file)
         print(new_issues_str)