[tor-commits] [tor/master] On failure to create extend info for an introduction point, don't leak.

asn at torproject.org asn at torproject.org
Tue Apr 30 16:24:45 UTC 2019


commit 7c98105d5617a0423c2d45941e7c0906de649128
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Apr 11 17:35:19 2019 -0400

    On failure to create extend info for an introduction point, don't leak.
    
    This is CID 1438152.  No backport needed: this path is already
    inside a BUG() guard.
---
 src/feature/rend/rendservice.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/feature/rend/rendservice.c b/src/feature/rend/rendservice.c
index 57475a64b..996e7b9a2 100644
--- a/src/feature/rend/rendservice.c
+++ b/src/feature/rend/rendservice.c
@@ -4227,6 +4227,7 @@ rend_consider_services_intro_points(time_t now)
        * directly ourselves. */
       intro->extend_info = extend_info_from_node(node, 0);
       if (BUG(intro->extend_info == NULL)) {
+        tor_free(intro);
         break;
       }
       intro->intro_key = crypto_pk_new();





More information about the tor-commits mailing list