[tor-commits] [tor/master] Fix a reverse-inull warning from coverity in new code.

nickm at torproject.org nickm at torproject.org
Wed Sep 5 12:35:03 UTC 2018


commit 79a7fbb79b7f5a5a8bb3552f3c071498a34e5b84
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Sep 5 08:34:14 2018 -0400

    Fix a reverse-inull warning from coverity in new code.
---
 src/lib/tls/tortls_openssl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib/tls/tortls_openssl.c b/src/lib/tls/tortls_openssl.c
index cfe859adf..5b1cdeec0 100644
--- a/src/lib/tls/tortls_openssl.c
+++ b/src/lib/tls/tortls_openssl.c
@@ -659,8 +659,7 @@ tor_tls_context_new(crypto_pk_t *identity, unsigned int key_lifetime,
   tls_log_errors(NULL, LOG_WARN, LD_NET, "creating TLS context");
   if (pkey)
     EVP_PKEY_free(pkey);
-  if (result)
-    tor_tls_context_decref(result);
+  tor_tls_context_decref(result);
   return NULL;
 }
 



More information about the tor-commits mailing list