[tor-commits] [tor/master] Initialize some locals in socks5 parsing code.

nickm at torproject.org nickm at torproject.org
Sun Oct 14 19:42:13 UTC 2018


commit dddecee291cadf391d93b569023f1f1e008880e8
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Sep 18 15:13:10 2018 -0400

    Initialize some locals in socks5 parsing code.
    
    These confused GCC LTO, which thought they might be used
    uninitialized.  I'm pretty sure that as long as 'res' indicates
    success, they will always be set to something, but let's unconfuse
    the compiler in any case.
---
 src/core/proto/proto_socks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/proto/proto_socks.c b/src/core/proto/proto_socks.c
index e2f233ad0..e23da7730 100644
--- a/src/core/proto/proto_socks.c
+++ b/src/core/proto/proto_socks.c
@@ -744,7 +744,7 @@ handle_socks_message(const uint8_t *raw_data, size_t datalen,
       res = SOCKS_RESULT_MORE_EXPECTED;
       goto end;
     } else if (req->socks_version != SOCKS_VER_5) {
-      int have_user_pass, have_no_auth;
+      int have_user_pass=0, have_no_auth=0;
       res = parse_socks5_methods_request(raw_data, req, datalen,
                                          &have_user_pass,
                                          &have_no_auth,





More information about the tor-commits mailing list