[tor-commits] [tor/master] report origin of mystery core file

[nickm at torproject.org]

commit 36ba506508ec5406be3d8c6a3b275fba069a7edf
Author: Taylor Yu <catalyst at torproject.org>
Date:   Thu Oct 11 20:25:41 2018 -0500

    report origin of mystery core file
    
    Report what program produced the mysterious core file that we
    occasionally see on Travis CI during make distcheck.  Closes ticket
    28024.
---
 .travis.yml         | 1 +
 Makefile.am         | 9 +++++++++
 changes/ticket28024 | 4 ++++
 3 files changed, 14 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 56d7dc073..de526fe0f 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -210,6 +210,7 @@ after_failure:
   - if [[ "$DISTCHECK" == "" ]]; then cat test-suite.log || echo "cat failed"; fi
   ## `make distcheck` puts it somewhere different.
   - if [[ "$DISTCHECK" != "" ]]; then make show-distdir-testlog || echo "make failed"; fi
+  - if [[ "$DISTCHECK" != "" ]]; then make show-distdir-core || echo "make failed"; fi
 
 after_success:
   ## If this build was one that produced coverage, upload it.
diff --git a/Makefile.am b/Makefile.am
index a0f513c75..e5c1be31b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -452,6 +452,15 @@ show-distdir-testlog:
 	else \
 	  cat $(distdir)/_build/$(TEST_SUITE_LOG); fi
 
+# Similarly, this relies on automake internals to run file on an
+# intermittent core file whose provenance is not known to us.  See
+# ticket 26787.
+show-distdir-core:
+	@if test -d "$(distdir)/_build/sub"; then \
+	  file $(distdir)/_build/sub/core ; \
+	else \
+	  file $(distdir)/_build/core; fi
+
 show-libs:
 	@echo $(TOR_INTERNAL_LIBS)
 
diff --git a/changes/ticket28024 b/changes/ticket28024
new file mode 100644
index 000000000..4b3952308
--- /dev/null
+++ b/changes/ticket28024
@@ -0,0 +1,4 @@
+  o Minor features (testing):
+    - Report what program produced the mysterious core file that we
+      occasionally see on Travis CI during make distcheck.  Closes
+      ticket 28024.