[tor-commits] [tor/release-0.3.4] Appveyor: always show the logs, and upload them as build artifacts

[nickm at torproject.org]

commit b8ce1de4bf55c7cbd786c4597638bfcb543c5f11
Author: teor <teor at torproject.org>
Date:   Thu Nov 15 21:04:17 2018 +1000

    Appveyor: always show the logs, and upload them as build artifacts
    
    Always show the configure and test logs, and upload them as build
    artifacts, when building for Windows using Appveyor CI.
    
    Implements 28459.
---
 .appveyor.yml       | 4 +++-
 changes/ticket28459 | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.appveyor.yml b/.appveyor.yml
index 7d8927ee3..21ae27767 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -60,7 +60,7 @@ test_script:
             Execute-Bash "VERBOSE=1 make -j2 check"
     }
 
-on_failure:
+on_finish:
 - ps: >-
     if ($env:compiler -eq "mingw") {
             $oldpath = ${env:Path} -split ';'
@@ -73,4 +73,6 @@ on_failure:
             Execute-Bash "tail -1000 config.log || true"
             Execute-Bash "cat test-suite.log || true"
     }
+
+on_failure:
 - cmd: C:\Python27\python.exe %APPVEYOR_BUILD_FOLDER%\scripts\test\appveyor-irc-notify.py irc.oftc.net:6697 tor-ci failure
diff --git a/changes/ticket28459 b/changes/ticket28459
new file mode 100644
index 000000000..6b5839b52
--- /dev/null
+++ b/changes/ticket28459
@@ -0,0 +1,4 @@
+  o Minor features (continuous integration, Windows):
+    - Always show the configure and test logs, and upload them as build
+      artifacts, when building for Windows using Appveyor CI.
+      Implements 28459.