[tor-commits] [tor/maint-0.3.3] Warn when an authority has voted for a version with a space in it.

[nickm at torproject.org]

commit 8ee1fe7aa76e0d5cb8704e397aa4cd81c875f1a1
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Jul 11 11:24:55 2018 -0400

    Warn when an authority has voted for a version with a space in it.
    
    Another way to try to prevent a recurrence of 26485.
---
 src/or/dirvote.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/or/dirvote.c b/src/or/dirvote.c
index 738ab35bc..e6a745612 100644
--- a/src/or/dirvote.c
+++ b/src/or/dirvote.c
@@ -673,6 +673,14 @@ compute_consensus_versions_list(smartlist_t *lst, int n_versioning)
   int min = n_versioning / 2;
   smartlist_t *good = smartlist_new();
   char *result;
+  SMARTLIST_FOREACH_BEGIN(lst, const char *, v) {
+    if (strchr(v, ' ')) {
+      log_warn(LD_DIR, "At least one authority has voted for a version %s "
+               "that contains a space. This probably wasn't intentional, and "
+               "is likely to cause trouble. Please tell them to stop it.",
+               escaped(v));
+    }
+  } SMARTLIST_FOREACH_END(v);
   sort_version_list(lst, 0);
   get_frequent_members(good, lst, min);
   result = smartlist_join_strings(good, ",", 0, NULL);
@@ -4002,4 +4010,3 @@ vote_routerstatus_find_microdesc_hash(char *digest256_out,
   }
   return -1;
 }
-