[tor-commits] [tor/master] changes: Add changes file for #24031.

nickm at torproject.org nickm at torproject.org
Tue Apr 3 23:16:05 UTC 2018


commit b503df2775d22cff0b74740357121ba5195e4a12
Author: Isis Lovecruft <isis at torproject.org>
Date:   Tue Apr 3 19:19:40 2018 +0000

    changes: Add changes file for #24031.
    
    (cherry picked from commit 5a8cdec3f8617920f19e3ab7707233ad3f02424f)
---
 changes/bug24031 | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/changes/bug24031 b/changes/bug24031
new file mode 100644
index 000000000..adffa46d8
--- /dev/null
+++ b/changes/bug24031
@@ -0,0 +1,13 @@
+  o Major bugfixes (protover, voting):
+    - Revise Rust implementation of protover to use a more memory-efficient
+      voting algorithm and corresponding data structures, thus avoiding a
+      potential (but small impact) DoS attack where specially crafted protocol
+      strings would expand to several potential megabytes in memory.  In the
+      process, several portions of code were revised to be methods on new,
+      custom types, rather than functions taking interchangeable types, thus
+      increasing type safety of the module.  Custom error types and handling
+      were added as well, in order to facilitate better error dismissal/handling
+      in outside crates and avoid mistakenly passing an internal error string to
+      C over the FFI boundary.  Many tests were added, and some previous
+      differences between the C and Rust implementations have been
+      remedied. Fixes 24031; bugfix on 0.3.3.1-alpha.





More information about the tor-commits mailing list