[tor-commits] [tor/master] Don't move gcov output to root directory

[nickm at torproject.org]

commit e31ffb274132662e2ce13439a52554022154773c
Author: Taylor Yu <catalyst at torproject.org>
Date:   Mon Oct 2 16:09:28 2017 -0500

    Don't move gcov output to root directory
    
    In scripts/test/coverage, avoid attempting to move gcov output files
    to the root directory when given no arguments.  Fixes bug 23741.
---
 changes/bug23741      | 4 ++++
 scripts/test/coverage | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/changes/bug23741 b/changes/bug23741
new file mode 100644
index 000000000..92f06f527
--- /dev/null
+++ b/changes/bug23741
@@ -0,0 +1,4 @@
+  o Minor bugfixes (testing):
+    - Prevent scripts/test/coverage from attempting to move gcov
+      output to the root directory.  Fixes bug 23741; bugfix on
+      0.2.5.1-alpha.
diff --git a/scripts/test/coverage b/scripts/test/coverage
index f4ae47582..f10c5afaa 100755
--- a/scripts/test/coverage
+++ b/scripts/test/coverage
@@ -29,7 +29,7 @@ for fn in src/or/*.c src/common/*.c; do
           gcov -o $on $fn
           if [ -e $GC ]
           then
-            if [ -n $dst ]
+            if [ -d "$dst" ]
             then
               mv $GC $dst/$GC
             fi