[tor-commits] [tor/maint-0.3.2] Downgrade evdns warnings about weird replies.

nickm at torproject.org nickm at torproject.org
Fri Nov 17 13:35:09 UTC 2017


commit 2a98fcb84859a8dfadf1c3430b901f0d8e6b3f06
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Nov 16 09:30:19 2017 -0500

    Downgrade evdns warnings about weird replies.
    
    evdns is allowed to give us unrecognized object types; it is allowed
    to give us non-IPv4 answer types, and it is (even) allowed to give
    us empty answers without an error.
    
    Closes ticket 24097.
---
 changes/ticket24097 | 4 ++++
 src/or/dns.c        | 5 +++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/changes/ticket24097 b/changes/ticket24097
new file mode 100644
index 000000000..36547a8dd
--- /dev/null
+++ b/changes/ticket24097
@@ -0,0 +1,4 @@
+  o Minor features (logging):
+    - Downgrade a pair of log messages that could occur when an exit's
+      resolver gave us an unusual (but not forbidden) response.
+      Closes ticket 24097.
diff --git a/src/or/dns.c b/src/or/dns.c
index 4194a29a6..7dc3575f5 100644
--- a/src/or/dns.c
+++ b/src/or/dns.c
@@ -1578,10 +1578,11 @@ evdns_callback(int result, char type, int count, int ttl, void *addresses,
                 escaped_safe_str(hostname));
       tor_free(escaped_address);
     } else if (count) {
-      log_warn(LD_EXIT, "eventdns returned only non-IPv4 answers for %s.",
+      log_info(LD_EXIT, "eventdns returned only unrecognized answer types "
+               " for %s.",
                escaped_safe_str(string_address));
     } else {
-      log_warn(LD_BUG, "eventdns returned no addresses or error for %s!",
+      log_info(LD_EXIT, "eventdns returned no addresses or error for %s.",
                escaped_safe_str(string_address));
     }
   }





More information about the tor-commits mailing list