[tor-commits] [sandboxed-tor-browser/master] Bug 22650: Make it clear that Pulse Audio is potentially dangerous to enable.

[yawning at torproject.org]

commit 9f016c247ab26362c3ba05ee8bb70fd306bfdd42
Author: Yawning Angel <yawning at schwanenlied.me>
Date:   Mon Jun 19 11:10:42 2017 +0000

    Bug 22650: Make it clear that Pulse Audio is potentially dangerous to enable.
    
    Per "Jann Horn of Google Project Zero", PulseAudio is a potential vector
    for sandbox escapes. While this is not part of the threat model in current
    releases, it should be documented as such in the UI.
---
 ChangeLog        | 2 ++
 data/ui/gtkui.ui | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 892230e..aea7c74 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 Changes in version 0.0.8 - UNRELEASED:
  * Bug 22648: Prevent the "easy" to fix X11 related sandbox escapes.
+ * Bug 22650: Make it clear that Pulse Audio is potentially dangerous
+   to enable.
 
 Changes in version 0.0.7 - 2017-05-22:
  * Bug 21977: Fetch install/update metadata files from a different location.
diff --git a/data/ui/gtkui.ui b/data/ui/gtkui.ui
index fc88a6f..1d8c4d5 100644
--- a/data/ui/gtkui.ui
+++ b/data/ui/gtkui.ui
@@ -528,7 +528,7 @@
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">start</property>
-                        <property name="label" translatable="yes">Pulse Audio</property>
+                        <property name="label" translatable="yes">Pulse Audio (UNSAFE)</property>
                       </object>
                       <packing>
                         <property name="expand">True</property>