[tor-commits] [tor/master] make check is required for all code submissions
nickm at torproject.org
nickm at torproject.org
Thu Jul 6 13:30:46 UTC 2017
commit 24d29c7ae0c523da7d59495438bbea10114da5e1
Author: Chelsea H. Komlo <chelsea.komlo at gmail.com>
Date: Wed Jun 28 20:36:59 2017 -0400
make check is required for all code submissions
integration tests should be run for feature changes/major patches
---
doc/HACKING/CodingStandards.md | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/doc/HACKING/CodingStandards.md b/doc/HACKING/CodingStandards.md
index c7787a7..da8ce62 100644
--- a/doc/HACKING/CodingStandards.md
+++ b/doc/HACKING/CodingStandards.md
@@ -6,7 +6,7 @@ tl;dr:
- Run configure with `--enable-fatal-warnings`
- Document your functions
- Write unit tests
- - Run `make test-full` to test against all unit and integration tests.
+ - Run `make check` before submitting a patch
- Run `make distcheck` to ensure the distribution works
- Add a file in `changes` for your branch.
@@ -32,6 +32,11 @@ Did you remember...
- To base your code on the appropriate branch?
- To include a file in the `changes` directory as appropriate?
+If you are submitting a major patch or new feature, or want to in the future...
+
+ - Set up Chutney and Stem, see HACKING/WritingTests.md
+ - Run `make test-full` to test against all unit and integration tests.
+
How we use Git branches
=======================
More information about the tor-commits
mailing list