[tor-commits] [tor/maint-0.2.9] Fix a clang compilation warning in rendservice.c

nickm at torproject.org nickm at torproject.org
Fri Dec 1 17:13:47 UTC 2017


commit 461e34bb3dec0f4f7234584806a224040f44c7ed
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Dec 1 12:13:15 2017 -0500

    Fix a clang compilation warning in rendservice.c
    
    Fixes bug 24480; bugfix on 0.2.5.16.
---
 changes/bug24480     | 3 +++
 src/or/rendservice.c | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/changes/bug24480 b/changes/bug24480
new file mode 100644
index 000000000..94e5b91a0
--- /dev/null
+++ b/changes/bug24480
@@ -0,0 +1,3 @@
+  o Minor bugfixes (compilation):
+    - Fix a signed/unsigned comparison warning introduced by our
+      fix to TROVE-2017-009. Fixes bug 24480; bugfix on 0.2.5.16.
diff --git a/src/or/rendservice.c b/src/or/rendservice.c
index ba8891ead..80e1e10a0 100644
--- a/src/or/rendservice.c
+++ b/src/or/rendservice.c
@@ -1162,7 +1162,7 @@ rend_service_introduce(origin_circuit_t *circuit, const uint8_t *request,
   time_t now = time(NULL);
   time_t elapsed;
   int replay;
-  size_t keylen;
+  ssize_t keylen;
 
   /* Do some initial validation and logging before we parse the cell */
   if (circuit->base_.purpose != CIRCUIT_PURPOSE_S_INTRO) {





More information about the tor-commits mailing list