[tor-commits] [tor/master] prop224: Add XXX about opaqueness of link_specifier_t.

[nickm at torproject.org]

commit 686891d67ebf69808ac3d2b2c98263d21a3fe143
Author: George Kadianakis <desnacked at riseup.net>
Date:   Tue Aug 8 21:25:04 2017 +0300

    prop224: Add XXX about opaqueness of link_specifier_t.
---
 src/trunnel/ed25519_cert.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/trunnel/ed25519_cert.h b/src/trunnel/ed25519_cert.h
index 782bd5958..0aa953d17 100644
--- a/src/trunnel/ed25519_cert.h
+++ b/src/trunnel/ed25519_cert.h
@@ -59,6 +59,10 @@ struct link_specifier_st {
 };
 #endif
 typedef struct link_specifier_st link_specifier_t;
+/** XXX hs_link_specifier_dup() violates the opaqueness of link_specifier_t by
+ *  taking its sizeof(). If we ever want to turn on TRUNNEL_OPAQUE we would
+ *  need to refactor that function to do the coyp by encoding and decoding the
+ *  object. */
 #if !defined(TRUNNEL_OPAQUE) && !defined(TRUNNEL_OPAQUE_ED25519_CERT)
 struct ed25519_cert_st {
   uint8_t version;