[tor-commits] [torbirdy/master] Add support for Thunderbird 52

[sukhbir at torproject.org]

commit 242efaf89da4731c3a859a1da69c9047eb60c69b
Author: Sukhbir Singh <sukhbir at torproject.org>
Date:   Mon Apr 3 05:54:35 2017 -0400

    Add support for Thunderbird 52
    
    - Bump minimum supported version to Thunderbird 45.0
    
    - Replace deprecated for-each-in loops with for-of for Thunderbird 52
    compatibility
---
 ChangeLog                     | 1 +
 chrome/content/emailwizard.js | 2 +-
 chrome/content/feedwizard.js  | 2 +-
 chrome/content/nntpwizard.js  | 2 +-
 components/torbirdy.js        | 2 +-
 install.rdf                   | 4 ++--
 6 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7ef279e..ba06f00 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,7 @@
  * Bug 20751: Enforce stronger ciphers in TorBirdy
  * Bug 6958, 16935, 19971: Add support for already torified keyserver
  communication using modern GnuPG
+ * The minimum supported Thunderbird version is 45.0 and the maximum is 52.*
  * Update default keyserver to OnionBalance hidden service pool
 
 0.2.1, 30 Nov 2016
diff --git a/chrome/content/emailwizard.js b/chrome/content/emailwizard.js
index d09ea5b..febc4d2 100644
--- a/chrome/content/emailwizard.js
+++ b/chrome/content/emailwizard.js
@@ -39,7 +39,7 @@ if(!org.torbirdy.emailwizard) org.torbirdy.emailwizard = new function() {
         pref_spec.push(['mail.server.%serverkey%.download_on_biff', false]);
     }
 
-    for each (var [pref_template, value] in pref_spec) {
+    for (var [pref_template, value] of pref_spec) {
         var pref = pref_template.replace("%idkey%", idkey);
         pref = pref.replace("%serverkey%", serverkey);
         pref = pref.replace("%outgoing%", outgoing);
diff --git a/chrome/content/feedwizard.js b/chrome/content/feedwizard.js
index e0698a1..9265a83 100644
--- a/chrome/content/feedwizard.js
+++ b/chrome/content/feedwizard.js
@@ -14,7 +14,7 @@ if (!org.torbirdy.feedwizard) org.torbirdy.feedwizard = new function() {
       ['mail.server.%serverkey%.login_at_startup', false]
     ];
 
-    for each (var [pref_template, value] in pref_spec) {
+    for (var [pref_template, value] of pref_spec) {
       let pref = pref_template.replace("%serverkey%", accountKey);
       Preferences.set(pref, value);
     }
diff --git a/chrome/content/nntpwizard.js b/chrome/content/nntpwizard.js
index 90051bb..e0f4978 100644
--- a/chrome/content/nntpwizard.js
+++ b/chrome/content/nntpwizard.js
@@ -15,7 +15,7 @@ if (!org.torbirdy.nntpwizard) org.torbirdy.nntpwizard = new function() {
       ['mail.server.%serverkey%.socketType', 3]
     ];
 
-    for each (var [pref_template, value] in pref_spec) {
+    for (var [pref_template, value] of pref_spec) {
       let pref = pref_template.replace("%serverkey%", key);
       Preferences.set(pref, value);
     }
diff --git a/components/torbirdy.js b/components/torbirdy.js
index a51efa2..3fca35c 100644
--- a/components/torbirdy.js
+++ b/components/torbirdy.js
@@ -697,7 +697,7 @@ TorBirdy.prototype = {
         ["mail.smtpserver.%smtp%.try_ssl", 3], // SSL/TLS
       ];
       for (let i = 0; i < smtpAccounts.length; i++) {
-        for each (var [pref_template, value] in smtpPrefs) {
+        for (var [pref_template, value] of smtpPrefs) {
           let pref = pref_template.replace("%smtp%", smtpAccounts[i]);
           if (this.prefs.prefHasUserValue(pref)) {
             let currentPref = Preferences.get(pref);
diff --git a/install.rdf b/install.rdf
index 4bddc6a..99b3372 100644
--- a/install.rdf
+++ b/install.rdf
@@ -12,8 +12,8 @@
     <!-- Thunderbird -->
     <Description>
       <em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id>
-      <em:minVersion>37.*</em:minVersion>
-      <em:maxVersion>45.*</em:maxVersion>
+      <em:minVersion>45.0</em:minVersion>
+      <em:maxVersion>52.*</em:maxVersion>
     </Description>
     </em:targetApplication>