[tor-commits] [torbutton/master] Bug 18743: Pref to hide 'Sign in to Sync' button in hamburger menu

[gk at torproject.org]

commit d127873b498fb83e4f608b82a8d382df25183dd3
Author: Arthur Edelstein <arthuredelstein at gmail.com>
Date:   Mon Apr 25 23:03:17 2016 -0700

    Bug 18743: Pref to hide 'Sign in to Sync' button in hamburger menu
---
 src/chrome/content/torbutton.js         | 16 ++++++++++++++++
 src/defaults/preferences/preferences.js |  1 +
 2 files changed, 17 insertions(+)

diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js
index a8a4ce6..a293c44 100644
--- a/src/chrome/content/torbutton.js
+++ b/src/chrome/content/torbutton.js
@@ -236,6 +236,9 @@ var torbutton_unique_pref_observer =
             case "extensions.torbutton.restrict_thirdparty":
                 torbutton_update_thirdparty_prefs();
                 break;
+            case "extensions.torbutton.hide_sync_ui":
+                torbutton_update_sync_ui();
+                break;
             case "gfx.font_rendering.opentype_svg.enabled":
             case "javascript.options.ion.content":
             case "javascript.options.typeinference":
@@ -625,6 +628,7 @@ function torbutton_init() {
     torbutton_update_toolbutton(mode);
     torbutton_update_statusbar(mode);
     torbutton_notify_if_update_needed();
+    torbutton_update_sync_ui();
 
     createTorCircuitDisplay(m_tb_control_host, m_tb_control_port, m_tb_control_pass,
                             "extensions.torbutton.display_circuit");
@@ -3566,4 +3570,16 @@ function torbutton_is_homepage_url(aURI)
   return (urls.indexOf(aURI.spec) >= 0);
 }
 
+// Check if "extensions.torbutton.hide_sync_ui" is enabled, and if so,
+// hide the "Sign in to Sync" button on the hamburger menu.
+function torbutton_update_sync_ui()
+{
+  try {
+    document.getElementById("PanelUI-footer-fxa").style.display =
+      getBoolPref("extensions.torbutton.hide_sync_ui") ? "none" : "";
+  } catch (e) {
+    torbutton_log(5, 'Error updating the Sync UI: ' + e);
+  }
+}
+
 //vim:set ts=4
diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js
index 548f4ed..c958ec4 100644
--- a/src/defaults/preferences/preferences.js
+++ b/src/defaults/preferences/preferences.js
@@ -9,6 +9,7 @@ pref("extensions.torbutton.display_panel",true);
 pref("extensions.torbutton.panel_style",'text');
 pref("extensions.torbutton at torproject.org.description", "chrome://torbutton/locale/torbutton.properties");
 pref("extensions.torbutton.updateNeeded", false);
+pref("extensions.torbutton.hide_sync_ui", true);
 
 // proxy prefs
 pref("extensions.torbutton.settings_method",'recommended');