[tor-commits] [doctor/master] Don't retry downloading votes

[atagar at torproject.org]

commit dc77970da41850c7ea51d56b975c13f35ce80d54
Author: Damian Johnson <atagar at torproject.org>
Date:   Sun Dec 20 14:15:53 2015 -0800

    Don't retry downloading votes
    
    Honestly I don't recall why we added retries here...
    
      https://gitweb.torproject.org/doctor.git/commit/?id=5e200e9
    
    Seems this mostly just masked when an authority was unavailable.
---
 .gitignore                  |    2 +-
 consensus_health_checker.py |   17 -----------------
 2 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/.gitignore b/.gitignore
index c320e41..e33b50c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,7 +4,7 @@ logs/
 data/contact_information.cfg
 data/fingerprints
 data/fingerprint_changes
+data/fingerprint_change_last_notified.cfg
 data/last_notified.cfg
 stem
-gmail_pw
 
diff --git a/consensus_health_checker.py b/consensus_health_checker.py
index 1224dfc..377fa0a 100755
--- a/consensus_health_checker.py
+++ b/consensus_health_checker.py
@@ -776,23 +776,6 @@ def _get_documents(label, resource):
       documents[authority.nickname] = query.run()[0]
       times_taken[authority.nickname] = time.time() - start_time
     except Exception as exc:
-      if label == 'vote':
-        # try to download the vote via the other authorities
-
-        v3ident = DIRECTORY_AUTHORITIES[authority.nickname].v3ident
-
-        query = downloader.query(
-          '/tor/status-vote/current/%s.z' % v3ident,
-          default_params = False,
-          validate = True,
-        )
-
-        query.run(True)
-
-        if not query.error:
-          documents[authority.nickname] = list(query)[0]
-          continue
-
       issues.append(Issue(Runlevel.ERROR, 'AUTHORITY_UNAVAILABLE', fetch_type = label, authority = authority.nickname, url = query.download_url, error = exc, to = [authority.nickname]))
 
   if label == 'consensus':