[tor-commits] [tor/master] improve a comment in memwipe

[nickm at torproject.org]

commit ce3b7ddb5494d51868bbaa1922f9bdb192907527
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Dec 10 09:03:47 2015 -0500

    improve a comment in memwipe
---
 src/common/crypto.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/common/crypto.c b/src/common/crypto.c
index 816423a..ba5c8a7 100644
--- a/src/common/crypto.c
+++ b/src/common/crypto.c
@@ -2817,7 +2817,11 @@ memwipe(void *mem, uint8_t byte, size_t sz)
    * variable.  It's an elaborate ruse to trick the compiler into not
    * optimizing out the "wipe this memory" code.  Read it if you like zany
    * programming tricks! In later versions of Tor, we should look for better
-   * not-optimized-out memory wiping stuff. */
+   * not-optimized-out memory wiping stuff...
+   *
+   * ...or maybe not.  In practice, there are pure-asm implementations of
+   * OPENSSL_cleanse() on most platforms, which ought to do the job.
+   **/
   OPENSSL_cleanse(mem, sz);
   /* Just in case some caller of memwipe() is relying on getting a buffer
    * filled with a particular value, fill the buffer.