[tor-commits] [stem/master] Missing list wrapper causing stacktraces during controller shutdown

[atagar at torproject.org]

commit ccda9b59044d2d95d8183811ac88e57f1abdb206
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat Apr 11 14:15:10 2015 -0700

    Missing list wrapper causing stacktraces during controller shutdown
    
    Traceback (most recent call last):
      File "/usr/lib/python3.2/threading.py", line 740, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.2/threading.py", line 693, in run
        self._target(*self._args, **self._kwargs)
      File "/home/atagar/Desktop/stem/stem/control.py", line 848, in _reader_loop
        control_message = self._socket.recv()
      File "/home/atagar/Desktop/stem/stem/socket.py", line 174, in recv
        self.close()
      File "/home/atagar/Desktop/stem/stem/socket.py", line 296, in close
        self._close()
      File "/home/atagar/Desktop/stem/stem/control.py", line 763, in _close
        self._notify_status_listeners(State.CLOSED)
      File "/home/atagar/Desktop/stem/stem/control.py", line 813, in _notify_status_listeners
        self._state_change_threads.append(notice_thread)
    AttributeError: 'filter' object has no attribute 'append'
---
 stem/control.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stem/control.py b/stem/control.py
index 52a8de3..4308eca 100644
--- a/stem/control.py
+++ b/stem/control.py
@@ -800,7 +800,7 @@ class BaseController(object):
         if expect_alive is not None and expect_alive != self.is_alive():
           return
 
-        self._state_change_threads = filter(lambda t: t.is_alive(), self._state_change_threads)
+        self._state_change_threads = list(filter(lambda t: t.is_alive(), self._state_change_threads))
 
         for listener, spawn in self._status_listeners:
           if spawn: