[tor-commits] [tor/master] Log more information when we fail to terminate a process.

[nickm at torproject.org]

commit 93c38b679f01bba7d85ddf5eeac51c462e782a62
Author: George Kadianakis <desnacked at riseup.net>
Date:   Thu Sep 6 17:03:11 2012 +0300

    Log more information when we fail to terminate a process.
---
 src/common/util.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/common/util.c b/src/common/util.c
index ce67252..4b1bce8 100644
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -3897,10 +3897,15 @@ tor_process_handle_destroy(process_handle_t *process_handle,
 
   if (also_terminate_process) {
     if (tor_terminate_process(process_handle) < 0) {
-      log_notice(LD_GENERAL, "Failed to terminate process with PID '%d'",
-                 tor_process_get_pid(process_handle));
+      log_notice(LD_GENERAL, "Failed to terminate process with "
+                 "PID '%d' ('%s').", tor_process_get_pid(process_handle),
+#ifdef _WIN32
+                 format_win32_error(GetLastError()));
+#else
+                 strerror(errno));
+#endif
     } else {
-      log_info(LD_GENERAL, "Terminated process with PID '%d'",
+      log_info(LD_GENERAL, "Terminated process with PID '%d'.",
                tor_process_get_pid(process_handle));
     }
   }