[tor-commits] [stem/master] Clarifying comments for the get_pid_by_open_file test
atagar at torproject.org
atagar at torproject.org
Sat Jul 7 20:18:33 UTC 2012
commit 4c7831fee70848b002b97d8d8dd4b30519ec9eb9
Author: Damian Johnson <atagar at torproject.org>
Date: Sat Jul 7 13:15:52 2012 -0700
Clarifying comments for the get_pid_by_open_file test
The prior fix is better for the test (working == better!), but makes it a bit
less self-descriptive. Adding a couple comments.
---
test/integ/util/system.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/integ/util/system.py b/test/integ/util/system.py
index 19ea5ea..522e576 100644
--- a/test/integ/util/system.py
+++ b/test/integ/util/system.py
@@ -303,11 +303,11 @@ class TestSystem(unittest.TestCase):
Checks the stem.util.system.get_pid_by_open_file function.
"""
- # we're not running with a control socket so this just exercises the
- # failure case
-
+ # check a directory that exists, but isn't claimed by any application
tmpdir = tempfile.mkdtemp()
self.assertEquals(None, stem.util.system.get_pid_by_open_file(tmpdir))
+
+ # check a directory that doesn't exist
os.rmdir(tmpdir)
self.assertEquals(None, stem.util.system.get_pid_by_open_file(tmpdir))
More information about the tor-commits
mailing list