[tor-commits] [stem/master] Skipping unreliable lsof test on osx
atagar at torproject.org
atagar at torproject.org
Thu Jan 5 18:40:50 UTC 2012
commit ed68e97e2d6a27ee979bf75b1e1b7f3df2d6c8d0
Author: Damian Johnson <atagar at torproject.org>
Date: Thu Jan 5 10:39:09 2012 -0800
Skipping unreliable lsof test on osx
On OSX the Quicklook process sometimes claims '/tmp' and possibly other common
paths too, making the test unreliable there. Skipping is better than a false
positive to avoiding the test when running on OSX.
Caught and patch submitted by gsathya
---
test/integ/util/system.py | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/test/integ/util/system.py b/test/integ/util/system.py
index dc06351..4f78099 100644
--- a/test/integ/util/system.py
+++ b/test/integ/util/system.py
@@ -196,6 +196,9 @@ class TestSystem(unittest.TestCase):
Checks the stem.util.system.get_pid_by_open_file function.
"""
+ # on macs this test is unreliable because Quicklook sometimes claims '/tmp'
+ if os.uname()[0] == "Darwin": self.skipTest("(unreliable due to Quicklook)")
+
# we're not running with a control socket so this just exercises the
# failure case
More information about the tor-commits
mailing list