[tor-commits] [stem/master] Downgrading protocolinfo version mismatch to INFO

atagar at torproject.org atagar at torproject.org
Mon Jan 2 22:34:23 UTC 2012


commit 5a988db9a78161240a9f3146936a57dfc0a6734e
Author: Damian Johnson <atagar at torproject.org>
Date:   Sun Jan 1 09:56:26 2012 -0800

    Downgrading protocolinfo version mismatch to INFO
    
    The response for PROTOCOLINFO queries do not necessarily need to be what we
    requested. We make a best effort to parse any response as a v1 response, and
    warned if the response was for something besides v1. Downgrading the warning
    from WARN to INFO since this is a valid tor response and, if we're still able
    to parse it, the user doesn't really need to be alerted.
    
    If the version mismatch can't be handled like a v1 response then that most
    likely *will* cause warnings or errors that we'll alert the user of.
---
 stem/connection.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/stem/connection.py b/stem/connection.py
index 7cb76be..6bd50fd 100644
--- a/stem/connection.py
+++ b/stem/connection.py
@@ -772,7 +772,7 @@ class ProtocolInfoResponse(stem.socket.ControlMessage):
         # an effort to parse like a v1 response.
         
         if self.protocol_version != 1:
-          log.warn("We made a PROTOCOLINFO v1 query but got a version %i response instead. We'll still try to use it, but this may cause problems." % self.protocol_version)
+          log.info("We made a PROTOCOLINFO version 1 query but got a version %i response instead. We'll still try to use it, but this may cause problems." % self.protocol_version)
       elif line_type == "AUTH":
         # Line format:
         #   AuthLine = "250-AUTH" SP "METHODS=" AuthMethod *("," AuthMethod)





More information about the tor-commits mailing list