[tor-commits] [tor/master] Add an XXX

nickm at torproject.org nickm at torproject.org
Mon May 23 05:22:49 UTC 2011


commit 36afdebe1ac08fe02c938a73270bd2f11999d677
Author: Robert Ransom <rransom.8774 at gmail.com>
Date:   Wed May 18 04:33:48 2011 -0700

    Add an XXX
---
 src/or/control.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/or/control.c b/src/or/control.c
index f7ff92a..47e7081 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -2894,6 +2894,9 @@ connection_control_process_inbuf(control_connection_t *conn)
     return 0;
   }
 
+  /* XXXX Why is this not implemented as a table like the GETINFO
+   * items are?  Even handling the plus signs at the beginnings of
+   * commands wouldn't be very hard with proper macros. */
   cmd_data_len = (uint32_t)data_len;
   if (!strcasecmp(conn->incoming_cmd, "SETCONF")) {
     if (handle_control_setconf(conn, cmd_data_len, args))





More information about the tor-commits mailing list