[or-cvs] r17833: {tor} fix a bug in download failure logging; don't do this "stop d (tor/trunk/src/or)

[arma at seul.org]

Author: arma
Date: 2008-12-31 09:11:46 -0500 (Wed, 31 Dec 2008)
New Revision: 17833

Modified:
   tor/trunk/src/or/directory.c
Log:
fix a bug in download failure logging; don't do this "stop
downloading forever" thing with bridge descriptor downloads.


Modified: tor/trunk/src/or/directory.c
===================================================================
--- tor/trunk/src/or/directory.c	2008-12-30 21:49:54 UTC (rev 17832)
+++ tor/trunk/src/or/directory.c	2008-12-31 14:11:46 UTC (rev 17833)
@@ -3330,8 +3330,8 @@
 
 /** Called when an attempt to download <b>dls</b> has failed with HTTP status
  * <b>status_code</b>.  Increment the failure count (if the code indicates a
- * real failure) and set <b>dls</b>->next_attempt_at to an appropriate time in
- * the future. */
+ * real failure) and set <b>dls</b>-\>next_attempt_at to an appropriate time
+ * in the future. */
 time_t
 download_status_increment_failure(download_status_t *dls, int status_code,
                                   const char *item, int server, time_t now)
@@ -3349,7 +3349,8 @@
 
   if (dls->n_download_failures < schedule_len)
     increment = schedule[dls->n_download_failures];
-  else if (dls->n_download_failures == IMPOSSIBLE_TO_DOWNLOAD)
+  else if (dls->n_download_failures == IMPOSSIBLE_TO_DOWNLOAD &&
+           dls->schedule != DL_SCHED_BRIDGE)
     increment = INT_MAX;
   else
     increment = schedule[schedule_len-1];
@@ -3360,7 +3361,7 @@
     dls->next_attempt_at = TIME_MAX;
 
   if (item) {
-    if (dls->next_attempt_at == 0)
+    if (increment == 0)
       log_debug(LD_DIR, "%s failed %d time(s); I'll try again immediately.",
                 item, (int)dls->n_download_failures);
     else if (dls->next_attempt_at < TIME_MAX)