[or-cvs] r17602: {tor} Note that a couple of line in control.c are supposed to be d (tor/trunk/src/or)

[nickm at seul.org]

Author: nickm
Date: 2008-12-11 16:11:28 -0500 (Thu, 11 Dec 2008)
New Revision: 17602

Modified:
   tor/trunk/src/or/control.c
Log:
Note that a couple of line in control.c are supposed to be dead-code.
I'm hoping not to have to litter the rest of our codebase with Coverity ignores, but I think these are the only one we need right now.

Modified: tor/trunk/src/or/control.c
===================================================================
--- tor/trunk/src/or/control.c	2008-12-11 21:11:26 UTC (rev 17601)
+++ tor/trunk/src/or/control.c	2008-12-11 21:11:28 UTC (rev 17602)
@@ -764,6 +764,8 @@
         msg = "553 Unable to set option";
         break;
       case SETOPT_OK:
+        /* coverity[dead_error_line]
+         * (It's okay if we can never get to this point.) */
         msg = "551 Internal error";
         tor_fragile_assert();
         break;
@@ -1191,8 +1193,11 @@
 
  err:
   tor_free(password);
-  if (!errstr)
+  if (!errstr) {
+    /* coverity[dead_error_line]
+     * (It's okay if we can never get to this point.) */
     errstr = "Unknown reason.";
+  }
   connection_printf_to_buf(conn, "515 Authentication failed: %s\r\n",
                            errstr);
   connection_mark_for_close(TO_CONN(conn));