[or-cvs] r17569: {tor} Fix a logic error that would automatically reject all but th (in tor/trunk: . src/or)

[nickm at seul.org]

Author: nickm
Date: 2008-12-10 17:57:41 -0500 (Wed, 10 Dec 2008)
New Revision: 17569

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/or/eventdns.c
Log:
Fix a logic error that would automatically reject all but the first configured DNS server.  Bugfix on 0.2.1.5-alpha.  Possible fix for part of 813/868.  Spotted by coderman

Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2008-12-10 22:28:00 UTC (rev 17568)
+++ tor/trunk/ChangeLog	2008-12-10 22:57:41 UTC (rev 17569)
@@ -1,4 +1,9 @@
 Changes in version 0.2.1.9-alpha - 200?-??-??
+  o Major bugfixes:
+    - Fix a logic error that would automatically reject all but the first
+      configured DNS server.  Bugfix on 0.2.1.5-alpha.  Possible fix for part
+      of bug 813/868.  Bug spotted by coderman.
+
   o Minor features:
     - Give a better error message when an overzealous init script says,
       "sudo -u username tor --user username".  Makes Bug 882 easier

Modified: tor/trunk/src/or/eventdns.c
===================================================================
--- tor/trunk/src/or/eventdns.c	2008-12-10 22:28:00 UTC (rev 17568)
+++ tor/trunk/src/or/eventdns.c	2008-12-10 22:57:41 UTC (rev 17569)
@@ -2224,7 +2224,7 @@
 	int err = 0;
 	if (server) {
 		do {
-			if (!sockaddr_eq(address, (struct sockaddr *)&server->address, 1)) {
+			if (sockaddr_eq(address, (struct sockaddr *)&server->address, 1)) {
 				log(EVDNS_LOG_DEBUG, "Duplicate nameserver.");
 				return 3;
 			}