[or-cvs] r14440: Added a few notes at the suggestion of nickm. (check/trunk/cgi-bin)

ioerror at seul.org ioerror at seul.org
Thu Apr 24 02:43:15 UTC 2008


Author: ioerror
Date: 2008-04-23 22:43:15 -0400 (Wed, 23 Apr 2008)
New Revision: 14440

Modified:
   check/trunk/cgi-bin/index.py
Log:
Added a few notes at the suggestion of nickm.


Modified: check/trunk/cgi-bin/index.py
===================================================================
--- check/trunk/cgi-bin/index.py	2008-04-24 02:17:27 UTC (rev 14439)
+++ check/trunk/cgi-bin/index.py	2008-04-24 02:43:15 UTC (rev 14440)
@@ -6,7 +6,9 @@
 # Written at ToorCon Seattle 2008 (Thanks for the great time h1kari!)
 # Thanks to Crispen for a power outlet :-)
 # 
-# Best used with the Debian package libapache2-mod-python
+# Best used with the Debian packages:
+#    python-dns
+#    libapache2-mod-python
 #
 # *   Copyright (c) 2008, Jacob Appelbaum   *
 # *  See LICENSE for licensing information  *
@@ -14,6 +16,8 @@
 
 # Unused for now
 # import antigravity
+# This is pydns and can be downloaded from http://pydns.sourceforge.net/ 
+# Or use the Debian package listed above
 import DNS 
 from mod_python import apache
 from mod_python import util
@@ -52,10 +56,11 @@
     # Ask the question and load the data into our answer
     answer=request.req()
 
+    # TODO: Don't make this a single point of return
+
     # Parse the answer and decide if it's allowing exits
     # 127.0.0.2 is an exit and NXDOMAIN is not
     if answer.header['status'] == "NXDOMAIN":
-	print "NXDOMAIN"
 	UsingTor=1
     else:
 	if answer.answers:
@@ -94,6 +99,8 @@
     queryString = req.subprocess_env['QUERY_STRING']
     user_supplied_lang = None
 
+    # TODO - Nick thinks this is horrible and should be done in a 
+    # more pythonish cgi manner
     if queryString :
         queries = queryString.split('&')
 



More information about the tor-commits mailing list