[or-cvs] r10111: fix some code comments, a wrapper, and add a todo item (in tor/trunk: doc src/common src/or)

[arma at seul.org]

Author: arma
Date: 2007-05-04 03:24:01 -0400 (Fri, 04 May 2007)
New Revision: 10111

Modified:
   tor/trunk/doc/TODO
   tor/trunk/src/common/tortls.c
   tor/trunk/src/or/main.c
   tor/trunk/src/or/rendcommon.c
Log:
fix some code comments, a wrapper, and add a todo item


Modified: tor/trunk/doc/TODO
===================================================================
--- tor/trunk/doc/TODO	2007-05-04 07:22:11 UTC (rev 10110)
+++ tor/trunk/doc/TODO	2007-05-04 07:24:01 UTC (rev 10111)
@@ -234,7 +234,8 @@
       trim down a lot.
   o Deprecations:
     o Remove v0 control protocol.
-P  - Packaging:
+    - can we deprecate 'getinfo network-status'?
+P - Packaging:
 P   - Can we switch to polipo? (Jun 1)
 P   - If we haven't replaced privoxy, lock down its configuration in all
       packages, as documented in tor-doc-unix.html

Modified: tor/trunk/src/common/tortls.c
===================================================================
--- tor/trunk/src/common/tortls.c	2007-05-04 07:22:11 UTC (rev 10110)
+++ tor/trunk/src/common/tortls.c	2007-05-04 07:24:01 UTC (rev 10111)
@@ -25,7 +25,7 @@
 #include <openssl/asn1.h>
 #include <openssl/bio.h>
 
-#define CRYPTO_PRIVATE
+#define CRYPTO_PRIVATE /* to import prototypes from crypto.h */
 
 #include "./crypto.h"
 #include "./tortls.h"

Modified: tor/trunk/src/or/main.c
===================================================================
--- tor/trunk/src/or/main.c	2007-05-04 07:22:11 UTC (rev 10110)
+++ tor/trunk/src/or/main.c	2007-05-04 07:24:01 UTC (rev 10111)
@@ -910,7 +910,7 @@
    * (if we've passed our internal checks). */
   if (time_to_fetch_directory < now) {
     /* Only caches actually need to fetch directories now. */
-    if (options->DirPort && !options->V1AuthoritativeDir) {
+    if (options->DirPort && !authdir_mode_v1(options)) {
       /* XXX actually, we should only do this if we want to advertise
        * our dirport. not simply if we configured one. -RD */
       if (any_trusted_dir_is_v1_authority())

Modified: tor/trunk/src/or/rendcommon.c
===================================================================
--- tor/trunk/src/or/rendcommon.c	2007-05-04 07:22:11 UTC (rev 10110)
+++ tor/trunk/src/or/rendcommon.c	2007-05-04 07:24:01 UTC (rev 10111)
@@ -233,8 +233,8 @@
 
 /* ==== Rendezvous service descriptor cache. */
 
-/** How old do we let hidden service descriptors get discarding them as too
- * old? */
+/** How old do we let hidden service descriptors get before discarding
+ * them as too old? */
 #define REND_CACHE_MAX_AGE (2*24*60*60)
 /** How wrong do we assume our clock may be when checking whether hidden
  * services are too old or too new? */