[or-cvs] r12913: Fix a crash when accessing hidden services: it would work th (in tor/trunk: . src/or)

[arma at seul.org]

Author: arma
Date: 2007-12-21 18:28:23 -0500 (Fri, 21 Dec 2007)
New Revision: 12913

Modified:
   tor/trunk/ChangeLog
   tor/trunk/src/or/rendclient.c
Log:
Fix a crash when accessing hidden services: it would work the first
time you use a given introduction point for your service, but
on subsequent requests we'd be using garbage memory. Fixed by
Karsten Loesing. Bugfix on 0.2.0.12-alpha.


Modified: tor/trunk/ChangeLog
===================================================================
--- tor/trunk/ChangeLog	2007-12-21 23:23:53 UTC (rev 12912)
+++ tor/trunk/ChangeLog	2007-12-21 23:28:23 UTC (rev 12913)
@@ -4,6 +4,10 @@
       unexpected (it used to be in our networkstatus when we started
       fetching it, but it isn't in our current networkstatus), and we
       aren't using bridges. Bugfix on 0.2.0.x.
+    - Fix a crash when accessing hidden services: it would work the first
+      time you use a given introduction point for your service, but
+      on subsequent requests we'd be using garbage memory. Fixed by
+      Karsten Loesing. Bugfix on 0.2.0.12-alpha.
 
   o Minor bugfixes:
     - Make the unit tests build again.

Modified: tor/trunk/src/or/rendclient.c
===================================================================
--- tor/trunk/src/or/rendclient.c	2007-12-21 23:23:53 UTC (rev 12912)
+++ tor/trunk/src/or/rendclient.c	2007-12-21 23:28:23 UTC (rev 12913)
@@ -549,7 +549,6 @@
       goto again;
     }
     extend_info_free(intro->extend_info);
-    intro = tor_malloc_zero(sizeof(rend_intro_point_t));
     intro->extend_info = extend_info_from_router(router);
   }
   return extend_info_dup(intro->extend_info);