[or-cvs] we now encrypt the entire cell on the link, not just the he...

[Roger Dingledine]

Update of /home/or/cvsroot/src/or
In directory moria.seul.org:/home/arma/work/onion/cvs/src/or

Modified Files:
	connection.c or.h 
Log Message:
we now encrypt the entire cell on the link, not just the header

previously padding cells, etc were distinguishable because their body was
all zero's


Index: connection.c
===================================================================
RCS file: /home/or/cvsroot/src/or/connection.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- connection.c	24 Aug 2002 07:55:49 -0000	1.14
+++ connection.c	24 Aug 2002 08:24:24 -0000	1.15
@@ -495,15 +495,15 @@
 
 int connection_write_cell_to_buf(cell_t *cellp, connection_t *conn) {
  
-  if(connection_encrypt_cell_header(cellp,conn)<0) {
+  if(connection_encrypt_cell(cellp,conn)<0) {
     return -1;
   }
 
   return connection_write_to_buf((char *)cellp, sizeof(cell_t), conn);
 }
 
-int connection_encrypt_cell_header(cell_t *cellp, connection_t *conn) {
-  char newheader[8];
+int connection_encrypt_cell(cell_t *cellp, connection_t *conn) {
+  cell_t newcell;
 #if 0
   int x;
   char *px;
@@ -516,8 +516,8 @@
   printf("\n");
 #endif
 
-  if(crypto_cipher_encrypt(conn->f_crypto, (char *)cellp, 8, newheader)) {
-    log(LOG_ERR,"Could not encrypt data for connection %s:%u.",conn->address,conn->port);
+  if(crypto_cipher_encrypt(conn->f_crypto, (char *)cellp, sizeof(cell_t), &newcell)) {
+    log(LOG_ERR,"Could not encrypt cell for connection %s:%u.",conn->address,conn->port);
     return -1;
   }
 #if 0
@@ -528,7 +528,7 @@
   printf("\n");
 #endif
 
-  memcpy(cellp,newheader,8);
+  memcpy(cellp,&newcell,sizeof(cell_t));
   return 0;
 }
 
@@ -697,7 +697,7 @@
   printf("\n");
 #endif
   /* decrypt */
-  if(crypto_cipher_decrypt(conn->b_crypto,crypted,8,(unsigned char *)outbuf)) {
+  if(crypto_cipher_decrypt(conn->b_crypto,crypted,sizeof(cell_t),(unsigned char *)outbuf)) {
     log(LOG_ERR,"connection_process_cell_from_inbuf(): Decryption failed, dropping.");
     return connection_process_inbuf(conn); /* process the remainder of the buffer */
   }
@@ -711,7 +711,7 @@
 #endif
 
   /* copy the rest of the cell */
-  memcpy((char *)outbuf+8, (char *)crypted+8, sizeof(cell_t)-8);
+//  memcpy((char *)outbuf+8, (char *)crypted+8, sizeof(cell_t)-8);
   cellp = (cell_t *)outbuf;
 //  log(LOG_DEBUG,"connection_process_cell_from_inbuf(): Decrypted cell is of type %u (ACI %u).",cellp->command,cellp->aci);
   command_process_cell(cellp, conn);

Index: or.h
===================================================================
RCS file: /home/or/cvsroot/src/or/or.h,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- or.h	24 Aug 2002 04:59:21 -0000	1.15
+++ or.h	24 Aug 2002 08:24:30 -0000	1.16
@@ -426,7 +426,7 @@
 int connection_state_is_open(connection_t *conn);
 
 int connection_send_destroy(aci_t aci, connection_t *conn);
-int connection_encrypt_cell_header(cell_t *cellp, connection_t *conn);
+int connection_encrypt_cell(cell_t *cellp, connection_t *conn);
 int connection_write_cell_to_buf(cell_t *cellp, connection_t *conn);
 
 int connection_process_inbuf(connection_t *conn);