[tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
---------------------------------+--------------------------
 Reporter:  arma                 |          Owner:  cohosh
     Type:  defect               |         Status:  reopened
 Priority:  Medium               |      Milestone:
Component:  Applications/GetTor  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  phw                  |        Sponsor:
---------------------------------+--------------------------
Changes (by phw):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm reopening this because we seem to have overlooked a bug. GetTor
 chocked earlier today and I found the following exception in its log file:
 {{{
 2020-05-29 19:04:43+0000 [email parser] Error while parsing email content:
 [Failure instance: Traceback: <class 'KeyError'>: 'command'
         /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:311:addCallbacks
         /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:654:_runCallbacks
         /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1613:unwindGenerator
         /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1529:_cancellableInlineCallbacks
         --- <exception caught here> ---
         /usr/lib/python3/dist-
 packages/twisted/internet/defer.py:1418:_inlineCallbacks
 /srv/gettor.torproject.org/home/gettor/gettor/parse/email.py:256:parse_callback
         ].
 }}}

 When GetTor detects an autoresponder, it returns an empty request
 dictionary, `{}`. GetTor then calls `parse_callback`, which assumes that
 the given request has the "command" key but that's not the case.

 Here's a fix:
 https://gitlab.torproject.org/tpo/anti-censorship/gettor-
 project/gettor/-/merge_requests/13

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34286#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online