[tor-bugs] #33617 [Core Tor/Tor]: Add a BandwidthStatistics option and consensus parameter

[Tor Bug Tracker & Wiki]

#33617: Add a BandwidthStatistics option and consensus parameter
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, prop313, ipv6,         |  Actual Points:
  outreachy-ipv6, network-team-roadmap-2020Q1    |
Parent ID:  #33052                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Sorry for the late review here.

 The code looks good, but I'm wondering that there is no unittest for this
 functionality. In particularly, I'm refering to
 `rep_hist_bw_stats_write()` and its position in
 `wep_hist_bw_stats_write()`. I think we need a unittest that tests the
 latter function and makes sure that `rep_hist_bw_stats_write()` will be
 called (or not be called) based on the consensus/torrc parameter, and that
 when it's called it does the right thing.

 Please let me know if you need help designing this unittest.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33617#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online