[tor-bugs] #34219 [Applications/Tor Browser]: Enable ZSTD support properly for Android

[Tor Bug Tracker & Wiki]

#34219: Enable ZSTD support properly for Android
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202005R,      |  Actual Points:
  GeorgKoppen202005                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  assigned => needs_review
 * keywords:  tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005 => tbb-rbm,
     TorBrowserTeam202005R, GeorgKoppen202005


Comment:

 We have at least two options to fix that:

 1) Installing `pkg-config` and pointing it to
 `/var/tmp/dist/zstd/lib/pkgconfig`
 2) Setting `ZSTD_CFLAGS` and `ZSTD_LIBS` properly.

 I opted for 2) as 1) needs `pkg-config` installed (presumable for all
 other platforms as well if we want to keep the container amount low) and
 we end up with `-L/var/tmp/dist/zstd/lib -lzstd` for `ld` which is not
 really needed. Pointing directly to the static lib we want to have used
 should be enough if I understand things correctly.

 `bug_34219` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_34219&id=40809c54c2e198cbe11d0d4f19bc9fd7c242166b)
 has a patch for review.

 It still needs some testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34219#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online