[tor-bugs] #34142 [Metrics/Onionperf]: Integrate reprocessing mode into analysis mode

[Tor Bug Tracker & Wiki]

#34142: Integrate reprocessing mode into analysis mode
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  karsten
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/Onionperf  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:  1.0
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 So, I started working on the user interface changes this morning and
 quickly realized that making the actual implementation changes at the same
 time would be trivial. That's why I changed both the user interface and
 the implementation.

 In short, I'm optimistic that it'll be as simple as accepting a directory
 (or file) in the `--tgen` and `--torctl` parameters where we only accept a
 single file right now. If the user passes one or two files there, we're
 running the analysis mode just as we do now. If the user passes two
 directories, we're running the reprocessing mode. The reprocessing
 subcommand will disappear.

 If we wanted, we could make the analysis mode more powerful by also
 accepting a mix of file and directory paths, in which case we would match
 whichever files contained in the directory have common dates with the
 given file. Or we could dump analysis files even if we don't find matching
 log files, just like we accept just a `--tgen` path or just a `--torctl`
 path right now. But I don't see how we'd need that functionality. My
 current patch above has the exact same functionality as right now, just
 with a shorter user interface. I'd say let's not add new functionality
 now, but save that for when we find out that we need it.

 Please review the attached commit (which I couldn't push to the Git
 server, because that is down right now). That commit is still based on
 Python 2, but I'm going to rebase it to our Python 3 branch once that's
 merged to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34142#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online