[tor-bugs] #34078 [Core Tor/Tor]: Fix compilation warnings with clang 10.0.0

[Tor Bug Tracker & Wiki]

#34078: Fix compilation warnings with clang 10.0.0
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 1


Comment:

 Okay, I've made some "prelim[inary]" branches that do everything except
 the bulk-replacement.  They are:
    * bug34078_prelim_035
    * bug34078_prelim_041  -- this is the only one that had a merge
 conflict
    * bug34078_prelim_042
    * bug34079_prelim_043


 Then I made a script to do the commit with the actual fix.  Two examples
 of its use are:
    * bug34078_035 -- PR at https://github.com/torproject/tor/pull/1882
    * bug34078_master -- PR at https://github.com/torproject/tor/pull/1883

 If these pass review, my plan is that we should merge the "prelim"
 branches as normal, and then one by one apply the fix script to each maint
 branch, then do an "ours" merge to the next branch before applying the
 script to that branch too.  In this way, we don't need to worry about
 conflicts from code movement.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34078#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online